-
Notifications
You must be signed in to change notification settings - Fork 61
Support batched logs from the worker #4174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hey @stuartc - this is all I've done on the lightning so far for batch logging. Just enough for local testing really. There's a lot of work we could do here to improve. I don't know how much appetite we have? |
|
Hi @midigofrank - as Stu is going to be tied up until the end of the year, can you help me with this? CC @theroinaochieng |
|
Hey @josephjclark , I'll have a look |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4174 +/- ##
==========================================
+ Coverage 89.32% 89.33% +0.01%
==========================================
Files 425 425
Lines 19899 19923 +24
==========================================
+ Hits 17775 17799 +24
Misses 2124 2124 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@josephjclark I have named the event |
Background
The production worker now supports batch logging (optionally).
What this means in short that instead of sending each log line straight to the
run:socketchannel, it'll save up a bunch of them and send a batch of logs in one go.This should reduce latency on log processing in the worker, and may eliminate even more lost runs.
Overview
This is a very simple, minimal PR which supports log events being set from the worker in batches.
It is designed to be backward compatible with batched and un-batched logs.
So basically the behaviour here is is simply:
logskey)logs, key, massage the payload into an array of 1 logThis PR does not do any batch uploading in the database. It probably makes sense to do this? But it feels beyond the scope of what I ought to be doing (with or without Claude's help)
I have not touched tests, but we should introduce a few tests against batched logs.
Closes #4123
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy