-
Notifications
You must be signed in to change notification settings - Fork 35
[DNM] fix parallel gather test dataset #1136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "import numpy as np\n", | ||
| "import os \n", | ||
| "import shutil\n", | ||
| "import openfe\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize it's not good practice to have this notebook in here, but I'd like to keep it for data provenance until I revisit our tests for cleanup.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
==========================================
- Coverage 93.53% 91.89% -1.64%
==========================================
Files 142 142
Lines 10635 10635
==========================================
- Hits 9947 9773 -174
- Misses 688 862 +174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
So just to confirm: |
f3a7c89 to
4d6038e
Compare
|
No API break detected ✅ |
|
this will be resolved by #1148 |
resolve #1130
Checklist
newsentryDevelopers certificate of origin