Skip to content

Conversation

@atravitz
Copy link
Contributor

resolve #1130

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz self-assigned this Feb 14, 2025
@atravitz atravitz requested a review from mikemhenry February 14, 2025 20:38
"import numpy as np\n",
"import os \n",
"import shutil\n",
"import openfe\n",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize it's not good practice to have this notebook in here, but I'd like to keep it for data provenance until I revisit our tests for cleanup.

@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (829ce37) to head (66b4715).
Report is 85 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1136      +/-   ##
==========================================
- Coverage   93.53%   91.89%   -1.64%     
==========================================
  Files         142      142              
  Lines       10635    10635              
==========================================
- Hits         9947     9773     -174     
- Misses        688      862     +174     
Flag Coverage Δ
fast-tests 91.89% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikemhenry
Copy link
Contributor

So just to confirm:
+40.6 MB (690%) is because we were missing attempt_1 and attempt_2? What if instead of adding this to the repo we used pooch to pull the data down instead? I'd really rather not add 40MBs to our repo if we can help it

@atravitz atravitz force-pushed the 1130-fix-parallel-gather-test-dataset branch from f3a7c89 to 4d6038e Compare February 17, 2025 19:05
@atravitz atravitz changed the title fix parallel gather test dataset [DNM] fix parallel gather test dataset Feb 19, 2025
@github-actions
Copy link

No API break detected ✅

@atravitz
Copy link
Contributor Author

this will be resolved by #1148

@atravitz atravitz closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix parallel gather test dataset

3 participants