Skip to content

Enable ESLint rule vue/no-template-shadow #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianhelba merged 1 commit into from
Jun 10, 2026
Merged

Enable ESLint rule vue/no-template-shadow #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions web/eslint.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ export default defineConfigWithVueTs(
"vue/valid-v-slot": ["error", { allowModifiers: true }],
// `any` is used everywhere and will be difficult to eliminate
"@typescript-eslint/no-explicit-any": "off",
// Temporary ignores until rules can be fixed
"vue/no-template-shadow": "off",
},
},

Expand Down
4 changes: 2 additions & 2 deletions web/src/components/projects/AccessControl.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,9 @@ onMounted(() => {
}
"
>
<template #item="{ props, item }">
<template #item="{ props: itemProps, item }">
<v-list-item
v-bind="props"
v-bind="itemProps"
:title="
item.first_name && item.last_name
? item.first_name + ' ' + item.last_name
Expand Down
4 changes: 2 additions & 2 deletions web/src/components/sidebars/ColormapEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,9 @@ onMounted(init);
class="py-2 marker-row"
>
<v-menu :close-on-content-click="false" open-on-hover location="end">
<template #activator="{ props }">
<template #activator="{ props: activatorProps }">
<div
v-bind="props"
v-bind="activatorProps"
class="color-square ma-0"
:style="{ backgroundColor: marker.color }"
/>
Expand Down
8 changes: 6 additions & 2 deletions web/src/components/sidebars/CompareLayerStyle.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,12 @@ const panels = ref(["A", "B"] as const);
emit('setLayerActive', props.activeLayer !== props.layer)
"
>
<template #activator="{ props }">
<v-icon v-tooltip="appliedStyleText" v-bind="props" icon="mdi-cog" />
<template #activator="{ props: activatorProps }">
<v-icon
v-tooltip="appliedStyleText"
v-bind="activatorProps"
icon="mdi-cog"
/>
</template>
<v-card
v-if="currentStyleSpecs.A && currentStyleSpecs.B"
Expand Down
40 changes: 20 additions & 20 deletions web/src/components/sidebars/LayerStyle.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,12 +605,12 @@ onMounted(resetCurrentStyle);
emit('setLayerActive', props.activeLayer !== props.layer)
"
>
<template #activator="{ props }">
<template #activator="{ props: activatorProps }">
<v-icon
v-tooltip="
appliedStyleName ? 'Style: ' + appliedStyleName : 'Configure styling'
"
v-bind="props"
v-bind="activatorProps"
icon="mdi-cog"
/>
</template>
Expand Down Expand Up @@ -663,9 +663,9 @@ onMounted(resetCurrentStyle);
:close-on-content-click="false"
location="start"
>
<template #activator="{ props }">
<template #activator="{ props: activatorProps }">
<v-icon
v-bind="props"
v-bind="activatorProps"
:disabled="!currentLayerStyle.id"
icon="mdi-pencil"
/>
Expand Down Expand Up @@ -868,9 +868,9 @@ onMounted(resetCurrentStyle);
open-on-hover
location="end"
>
<template #activator="{ props }">
<template #activator="{ props: activatorProps }">
<div
v-bind="props"
v-bind="activatorProps"
class="color-square"
:style="{
backgroundColor: group.single_color,
Expand Down Expand Up @@ -908,8 +908,8 @@ onMounted(resetCurrentStyle);
(v: Colormap) => setGroupColormap(group.name, v)
"
>
<template #item="{ props, item }">
<v-list-item v-bind="props">
<template #item="{ props: itemProps, item }">
<v-list-item v-bind="itemProps">
<template #append>
<v-icon
v-if="
Expand Down Expand Up @@ -1261,9 +1261,9 @@ onMounted(resetCurrentStyle);
open-on-hover
location="end"
>
<template #activator="{ props }">
<template #activator="{ props: activatorProps }">
<div
v-bind="props"
v-bind="activatorProps"
class="color-square"
:style="{
backgroundColor: group.single_color,
Expand Down Expand Up @@ -1312,8 +1312,8 @@ onMounted(resetCurrentStyle);
}
"
>
<template #item="{ props, item }">
<v-list-item v-bind="props">
<template #item="{ props: itemProps, item }">
<v-list-item v-bind="itemProps">
<template #append>
<v-chip
v-if="(item as any).sample_label"
Expand Down Expand Up @@ -1353,8 +1353,8 @@ onMounted(resetCurrentStyle);
(v: Colormap) => setGroupColormap(group.name, v)
"
>
<template #item="{ props, item }">
<v-list-item v-bind="props">
<template #item="{ props: itemProps, item }">
<v-list-item v-bind="itemProps">
<template #append>
<v-icon
v-if="
Expand Down Expand Up @@ -1561,9 +1561,9 @@ onMounted(resetCurrentStyle);
:disabled="!group.visible"
location="end"
>
<template #activator="{ props }">
<template #activator="{ props: activatorProps }">
<div
v-bind="props"
v-bind="activatorProps"
class="color-square"
:style="{
backgroundColor: group.colormap.null_color,
Expand Down Expand Up @@ -1706,9 +1706,9 @@ onMounted(resetCurrentStyle);
placeholder="Select property"
hide-details
>
<template #item="{ props, item }">
<template #item="{ props: itemProps, item }">
<v-list-item
v-bind="props"
v-bind="itemProps"
:disabled="!(item as any).range"
>
<template #append>
Expand Down Expand Up @@ -1891,8 +1891,8 @@ onMounted(resetCurrentStyle);
hide-details
@update:model-value="(v) => updateFilterBy(filter.id, v)"
>
<template #item="{ props, item }">
<v-list-item v-bind="props">
<template #item="{ props: itemProps, item }">
<v-list-item v-bind="itemProps">
<template #append>
<v-chip
v-if="(item as any).sample_label"
Expand Down