fix: Ignore z coordinates on gl line features#1488
Merged
Conversation
Closes #1486. We don't support z coordinates yet (ever?), so disable them until we do. See also #963. There we claimed that we ignored z coordinates on lines, so this is fixing a bug. One testing concern -- this doesn't seem to reproduce in the xvfb test environment; for instance changing the z value in the lines tutorial makes the lines vanish on both Chrome and Firefox, but not in the xvfb rendered chrome and firefox. As a result, there is no test added to ensure that this works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1486.
We don't support z coordinates yet (ever?), so disable them until we do.
See also #963. There we claimed that we ignored z coordinates on lines, so this is fixing a bug.
One testing concern -- this doesn't seem to reproduce in the xvfb test environment; for instance changing the z value in the lines tutorial makes the lines vanish on both Chrome and Firefox, but not in the xvfb rendered chrome and firefox. As a result, there is no test added to ensure that this works.