fix: search_token returns None for chainless queries due to incorrect guard placement#133
Open
bigeez wants to merge 1 commit intoOpenGradient:mainfrom
Open
fix: search_token returns None for chainless queries due to incorrect guard placement#133bigeez wants to merge 1 commit intoOpenGradient:mainfrom
bigeez wants to merge 1 commit intoOpenGradient:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
search_tokeninonchain/tokens/metadata.pyincorrectly returnsNonefor any token search that doesn't pass a chain argument.
The guard
if chain not in SUPPORTED_CHAINS: return Nonewas at the sameindentation level as
if chain:, meaning it always ran even when chain wasNone — killing chainless fallback searches silently.
Fix
Indented the
SUPPORTED_CHAINScheck inside theif chain:block so itonly runs when a chain is actually provided. Chainless searches now correctly
fall through to
_search_token_on_dexscreener.Testing