fix: rename shadowed variable 'token' to 'result' in search_token tool#135
Open
bigeez wants to merge 2 commits intoOpenGradient:mainfrom
Open
fix: rename shadowed variable 'token' to 'result' in search_token tool#135bigeez wants to merge 2 commits intoOpenGradient:mainfrom
bigeez wants to merge 2 commits intoOpenGradient:mainfrom
Conversation
…d allow_origin_regex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In
agent/tools.py, thesearch_tokentool function usestokenas boththe input parameter (a
str) and the result variable (aTokenMetadataobject):This is variable shadowing — the parameter is silently overwritten by the
result. It works by luck (Python evaluates the right side before assignment)
but the type annotation is lying and any future refactor could easily break this.
Fix
Renamed the result variable to
resultfor clarity and correctness.Related
Similar shadowing issue was fixed in
onchain/tokens/metadata.py.