fix: add missing chainId to inference transaction in _send_tx_with_revert_handling()#234
Open
amathxbt wants to merge 1 commit intoOpenGradient:mainfrom
Open
fix: add missing chainId to inference transaction in _send_tx_with_revert_handling()#234amathxbt wants to merge 1 commit intoOpenGradient:mainfrom
amathxbt wants to merge 1 commit intoOpenGradient:mainfrom
Conversation
…rt_handling Every other transaction built in alpha.py (new_workflow, run_workflow, _register_with_scheduler) correctly includes chainId in the transaction dict. _send_tx_with_revert_handling — which handles the primary infer() path — was the only method missing it. Without chainId, Web3.py signs transactions without EIP-155 replay protection. This can cause RPC nodes to reject the transaction or behave unexpectedly in multi-chain/testnet environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix: Missing
chainIdin_send_tx_with_revert_handling()— affects allinfer()callsSummary
_send_tx_with_revert_handling()inalpha.pyis missingchainIdwhen building the inference transaction. Every other transaction in the same file includes it — this method was the only exception.The Bug
Compare with every other transaction in the same file:
Impact
_send_tx_with_revert_handlingis called byinfer()— the primary and most commonly used Alpha Testnet methodchainId, Web3.py signs the transaction without EIP-155 replay protectionchainId; others silently accept them but the transaction may be replayable on other chainsinfer()behave differently from every other transaction inalpha.pyFix