fix: add _get_model_id() helper to prevent IndexError on missing '/' separator#258
Open
teyrebaz33 wants to merge 1 commit intoOpenGradient:mainfrom
Open
Conversation
…separator Fixes OpenGradient#249 Both completion() and chat() were calling model.split('/')[1] directly, which raises IndexError when the model string has no '/' separator. Added a _get_model_id() helper function that: - Extracts the model value from TEE_LLM enum or plain string - Raises a clear ValueError with a helpful message if the format is invalid - Is used in both completion() and chat() methods Matches the fix suggested in the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #249
Problem
Both
completion()andchat()inllm.pywere callingmodel.split('/')[1]directly. When a caller passes a model string without a/separator, this raises an unhelpfulIndexError: list index out of range.Fix
Added a
_get_model_id()helper function that:TEE_LLMenum instances and plain stringsValueErrorwith an actionable message if the format is invalidcompletion()andchat()methodsChanges
src/opengradient/client/llm.py: Added_get_model_id()helper and replaced both raw.split('/')[1]calls