fix: close old HTTP client in RegistryTEEConnection.reconnect()#260
Open
teyrebaz33 wants to merge 1 commit intoOpenGradient:mainfrom
Open
fix: close old HTTP client in RegistryTEEConnection.reconnect()#260teyrebaz33 wants to merge 1 commit intoOpenGradient:mainfrom
teyrebaz33 wants to merge 1 commit intoOpenGradient:mainfrom
Conversation
Fixes OpenGradient#247 RegistryTEEConnection.reconnect() was replacing self._active without closing the old HTTP client, leaking file descriptors on long-running apps that reconnect frequently. StaticTEEConnection.reconnect() already handled this correctly. Applied the same pattern: save old_client before reconnecting, then aclose() it after the new connection is established.
kylexqian
approved these changes
Apr 9, 2026
Collaborator
kylexqian
left a comment
kylexqian
left a comment
There was a problem hiding this comment.
Good fix, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #247
Problem
RegistryTEEConnection.reconnect()was replacingself._activewith a new connection without closing the old HTTP client first. In long-running apps that reconnect frequently (e.g. every 5 minutes), this leaks file descriptors and can eventually exhaust system resources.Fix
Applied the same pattern already used in
StaticTEEConnection.reconnect():aclose()the old client after successful reconnectChanges
src/opengradient/client/tee_connection.py: FixedRegistryTEEConnection.reconnect()to close old HTTP client