fix: add missing dependencies and correct badge URLs#264
Open
golldyck wants to merge 2 commits intoOpenGradient:mainfrom
Open
fix: add missing dependencies and correct badge URLs#264golldyck wants to merge 2 commits intoOpenGradient:mainfrom
golldyck wants to merge 2 commits intoOpenGradient:mainfrom
Conversation
Author
|
Hi @adambalogh @kylexqian — this PR fixes bugs I found during a full audit of OpenGradient's public repositories. Would appreciate a review when you get a chance. Happy to address any feedback. Thanks! |
kylexqian
previously approved these changes
Apr 9, 2026
Collaborator
|
Need to update the uv.lock as well -- do you mind doing this? |
Author
|
Done! Updated the uv.lock file to include the newly added dependencies (httpx and requests-toolbelt). Please check if everything looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pyproject.tomlis missingrequests-toolbeltandhttpxas direct dependencies, causingImportErrorwhen users install the SDK via pip and useModelHub.upload()or the LLM/twins clients. Additionally, README CI badge URLs point to a non-existentOpenGradient/sdkrepo.Fix
Added the missing dependencies to
pyproject.toml, corrected the Rufftarget-versionto matchrequires-python, fixed CI badge URLs, and removed unreachable code incli.py.Changes
pyproject.toml— Addedrequests-toolbeltandhttpxto[project.dependencies], changed Rufftarget-versionfrom"py310"to"py311"to matchrequires-python = ">=3.11"README.md— Fixed CI badge URLs fromOpenGradient/sdktoOpenGradient/OpenGradient-SDKsrc/opengradient/cli.py— Removed unreachable code afterraise NotImplementedErroringenerate_imageTesting
requests-toolbeltandhttpxare listed in dependenciesCloses #265