replace legacy gasPrice with EIP-1559 fee fields in Alpha client#267
Open
verseon0980 wants to merge 1 commit intoOpenGradient:mainfrom
Open
replace legacy gasPrice with EIP-1559 fee fields in Alpha client#267verseon0980 wants to merge 1 commit intoOpenGradient:mainfrom
verseon0980 wants to merge 1 commit intoOpenGradient:mainfrom
Conversation
Signed-off-by: verseon0980 <klokrc74@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Every transaction sent by the Alpha client uses the legacy gasPrice field
instead of the EIP-1559 fields maxFeePerGas and maxPriorityFeePerGas.
Affected functions in src/opengradient/client/alpha.py:
Why This Is a Problem
Base Sepolia and the OpenGradient network both use EIP-1559 transaction
pricing. When a transaction is built with gasPrice instead of
maxFeePerGas and maxPriorityFeePerGas, two things can go wrong:
the call fails.
to overpay on gas because the fee estimation is less efficient.
This means all on-chain operations in the Alpha client including model
inference, workflow deployment, scheduler registration, and workflow
execution are all affected.
Fix
Replace gasPrice with the two EIP-1559 fields in all four transaction builders:
"maxFeePerGas": self._blockchain.eth.gas_price,
"maxPriorityFeePerGas": self._blockchain.eth.gas_price,
Files Changed
builders to use EIP-1559 fee fields