fix(examples): reuse existing LLM instance in langchain_react_agent.py#274
Open
verseon0980 wants to merge 1 commit intoOpenGradient:mainfrom
Open
fix(examples): reuse existing LLM instance in langchain_react_agent.py#274verseon0980 wants to merge 1 commit intoOpenGradient:mainfrom
verseon0980 wants to merge 1 commit intoOpenGradient:mainfrom
Conversation
Signed-off-by: verseon0980 <klokrc74@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
examples/langchain_react_agent.pycreates two separate LLM instancesusing the same private key:
Each
og.LLM()constructor makes a blocking on-chain RPC call to theTEE registry to set up the connection. Calling it twice with the same
private key means the example triggers double the blockchain connections
and double the registry lookups for no reason.
og.agents.langchain_adapter()already accepts aclient=parameterspecifically designed to receive an existing LLM instance. The
private_key=parameter is only needed when no existing client is passed.Passing both means the existing client is ignored and a brand new one
is created internally anyway.
Affected file:
examples/langchain_react_agent.pylines 21-26Fix
Pass the already-created
llm_clientinstance directly tolangchain_adapter()via theclient=parameter instead of passingprivate_key=again. This reuses the existing connection with zeroextra RPC calls.
Changes
examples/langchain_react_agent.py: replacedprivate_key=private_keyargument in
langchain_adapter()withclient=llm_client