fix: correct repository URLs and docstring examples#1
Open
golldyck wants to merge 2 commits intoOpenGradient:mainfrom
Open
fix: correct repository URLs and docstring examples#1golldyck wants to merge 2 commits intoOpenGradient:mainfrom
golldyck wants to merge 2 commits intoOpenGradient:mainfrom
Conversation
Author
|
Hi @adambalogh @kylexqian — this PR fixes bugs I found during a full audit of OpenGradient's public repositories. Would appreciate a review when you get a chance. Happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pyproject.tomlrepository URLs point tolangchain-ai/langchaininstead ofOpenGradient/og-langchain, causing PyPI and GitHub to link to the wrong project. Docstring examples intoolkits.pycontain errors that causeTypeErrorwhen copied by developers.Fix
Updated all repository URLs to point to the correct OpenGradient repo. Fixed docstring examples to use correct function signatures and type hints.
Changes
pyproject.toml— ChangedrepositoryURL and Source Code URL fromlangchain-ai/langchaintoOpenGradient/og-langchainlangchain_opengradient/toolkits.py— Removed non-existenttool_typeparameter fromcreate_read_workflow_tooldocstring example, fixedGetInputData()→GetInputData(reference not call) increate_run_model_tooldocstring, correctedmodel_input_providertype hint fromInferenceResulttodictTesting
Closes #2