fix: correct README instructions and remove dead code#52
Open
golldyck wants to merge 1 commit intoOpenGradient:mainfrom
Open
fix: correct README instructions and remove dead code#52golldyck wants to merge 1 commit intoOpenGradient:mainfrom
golldyck wants to merge 1 commit intoOpenGradient:mainfrom
Conversation
Author
|
Hi @adambalogh @kylexqian — this PR fixes bugs I found during a full audit of OpenGradient's public repositories. Would appreciate a review when you get a chance. Happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
README references a non-existent
gemini-3-pro-previewmodel, tells users to runpip install -r requirements.txt(file does not exist), and usesclaude-3.7-sonnetin the curl example which is not in the model registry. Dead code exists in typing_utils.py and an unused constant in defaults.py.Fix
Corrected the README to match the actual model registry and build system. Removed dead code branches and unused constants.
Changes
README.md— Replacedgemini-3-pro-previewwithgemini-3-flash-preview, changed install command frompip install -r requirements.txttouv sync, fixed curl example model to one that exists in the registrytee_gateway/typing_utils.py— Removed dead code branch for Python < 3.7 (project requires >= 3.12)tee_gateway/controllers/defaults.py— Removed unusedHTTP_BACKEND_SERVERconstantTesting
tee_gateway/model_registry.pypyproject.tomlis the actual dependency source (no requirements.txt)Closes #53