fix: correct reshapeArray for N-dimensional tensors and restore gas estimation#3
Open
golldyck wants to merge 2 commits intoOpenGradient:mainfrom
Open
fix: correct reshapeArray for N-dimensional tensors and restore gas estimation#3golldyck wants to merge 2 commits intoOpenGradient:mainfrom
golldyck wants to merge 2 commits intoOpenGradient:mainfrom
Conversation
Author
|
Hi @adambalogh @kylexqian — this PR fixes bugs I found during a full audit of OpenGradient's public repositories. Would appreciate a review when you get a chance. Happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
reshapeArrayinsrc/utils.tsusesshape.slice(0, -1)which removes the last dimension instead of the first, silently corrupting data for any tensor with 3+ dimensions. Additionally,llmChatinsrc/client.tshas gas estimation commented out and replaced with a hardcoded value.Fix
Changed
shape.slice(0, -1)toshape.slice(1)so the function correctly passes remaining dimensions when recursing. Restored proper gas estimation forllmChatand replacedvarwithconst.Changes
src/utils.ts— FixedreshapeArrayto useshape.slice(1)instead ofshape.slice(0, -1), correctly consuming the first dimension and passing the restsrc/client.ts— RestoredestimateGas()call inllmChat(was hardcoded to100000), replacedvarwithconston line ~142Testing
reshapeArray([1..24], [2,3,4])produces correct 2x3x4 nested arrayinfer,llmCompletion, andllmChatall use consistent gas estimationreshapeArrayare affected by the fixCloses #4