[carla] Fix segfault on LaneCrossingCalculator nullptr access- #9591 - #3617
Merged
Conversation
#9591 LaneCrossingCalculator tried to create LaneMarking objects without check if the respective information object exists at all. Description Running manual_control.py on a custom made map showed segfaults. Debugging lead to a nullptr access on the not existing information from the map. OpenDRIVE maps are valid even without lane marking information (or with a reduced set of it). This change prevents from the segfault an just returns an empty list of markings. Fixes # Where has this been tested? Platform(s): ... Ubuntu 24.04 Python version(s): ... 3.12 Unreal Engine version(s): ... 4.26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9591
LaneCrossingCalculator tried to create LaneMarking objects without check if the respective information object exists at all.
Description
Running manual_control.py on a custom made map showed segfaults. Debugging lead to a nullptr access on the not existing information from the map. OpenDRIVE maps are valid even without lane marking information (or with a reduced set of it). This change prevents from the segfault an just returns an empty list of markings.
Fixes #
Where has this been tested?
Platform(s): ... Ubuntu 24.04
Python version(s): ... 3.12
Unreal Engine version(s): ... 4.26