Count ActionEvent tool calls in efficiency metrics#78
Open
DB825 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActionEventmessages as tool calls in efficiency metrics usingtool_nametool_callspathTokenEventprompt-token accounting and update the metrics tests for the current flattened outputWhy
CodeSearchGeneratorserializes OpenHands SDK conversation events withevent.model_dump()before callingcompute_all_efficiency_metrics. Tool invocations in those serialized trajectories are represented asActionEventdictionaries, butcompute_tool_call_metricsonly counted assistant messages containing OpenAI-styletool_calls.That could undercount tool usage for SDK event dumps and report
avg_tool_calls_per_stepas zero even when the agent used tools.Tests
python -m py_compile src\metrics\efficiency_metrics.py tests\metrics\test_efficiency_metrics.pypython -m pytest tests\metrics\test_efficiency_metrics.py -qpython -m pytest tests\metrics -qpython -m ruff check src\metrics\efficiency_metrics.py tests\metrics\test_efficiency_metrics.py