Skip to content

Conversation

@xrgzs
Copy link
Member

@xrgzs xrgzs commented Jan 9, 2026

Description / 描述

重新加回 PDF Viewer,使用 Embed PDF 实现,体验比 PDF.js 更好。

Motivation and Context / 背景

https://github.com/embedpdf/embed-pdf-viewer

Relates to OpenListTeam/OpenList#1724

How Has This Been Tested? / 测试

  • 确认 wasm 是否正常
  • 确认 i18n 是否正常
  • 确认 跨域是否正常(连PDF.js iframe 不正常的都正常)
  • 确认 引入后体积增加大小(约10MB)
  • Lite 版本精简/在线请求CDN(由于CDN不方便使用,直接给Lite版本移除)

Checklist / 检查清单

  • I have read the CONTRIBUTING document.
    我已阅读 CONTRIBUTING 文档。
  • I have formatted my code with go fmt or prettier.
    我已使用 go fmtprettier 格式化提交的代码。
  • I have added appropriate labels to this PR (or mentioned needed labels in the description if lacking permissions).
    我已为此 PR 添加了适当的标签(如无权限或需要的标签不存在,请在描述中说明,管理员将后续处理)。
  • I have requested review from relevant code authors using the "Request review" feature when applicable.
    我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
  • I have updated the repository accordingly (If it’s needed).
    我已相应更新了相关仓库(若适用)。

@xrgzs xrgzs added enhancement New feature or request javascript Pull requests that update javascript code labels Jan 9, 2026
@xrgzs xrgzs changed the title feat(proviews): add PDF Viewer (embedpdf) feat(previews): add PDF Viewer (embedpdf) Jan 9, 2026
@xrgzs xrgzs marked this pull request as ready for review January 10, 2026 06:48
@xrgzs xrgzs requested review from PIKACHUIM and removed request for PIKACHUIM January 10, 2026 06:48
@xrgzs xrgzs marked this pull request as draft January 10, 2026 06:55
@xrgzs

This comment was marked as resolved.

@xrgzs xrgzs marked this pull request as ready for review January 15, 2026 12:37
@xrgzs xrgzs requested a review from PIKACHUIM January 17, 2026 13:30
xrgzs added 6 commits January 18, 2026 13:36
Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
@jyxjjj
Copy link
Member

jyxjjj commented Jan 19, 2026

和CDN这块没看懂

  1. 是否Lite版本直接删除了?
  2. 被折叠评论中提及改成CDN,是指?

@xrgzs
Copy link
Member Author

xrgzs commented Jan 20, 2026

  1. 是否Lite版本直接删除了?

目前是这样,Lite 版本不使用此预览组件,vite不会打包。

  1. 被折叠评论中提及改成CDN,是指?

这个库即使不引入 wasm,vite也会将其打包到 dist 中,所以干脆 Lite 直接删除,另外这个 wasmUrl 需要绝对URL,之前尝试相对URL,结果不成功 fallbak 到 jsd cdn。目前已修复。

Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants