Skip to content

Conversation

@PaulaSp3
Copy link
Contributor

@PaulaSp3 PaulaSp3 commented Jul 16, 2024

  1. If calcGeneration = True : the iteration of cell - calculation is done per generation (results differ compared to "standard" simulation -> see python runStandardTestsCom4FlowPy.py.

  2. Add two benchmark tests for FlowPy (in 1. real topography: Arzler Alm, 2. generic topography, as in FlowPy-paper)
    runsStandardTestsCom4FlowPy.py executes FlowPy with standard parameters in both topgraphys and compares the results with 'true' results (from the original master branch/ Flow-Py paper results)
    AIMEC analyses (as in runsStandardTestsCom1DFA.py) are not done here.

@PaulaSp3 PaulaSp3 requested a review from ahuber-bfw July 16, 2024 09:40
@pep8speaks
Copy link

pep8speaks commented Jul 16, 2024

Hello @PaulaSp3! Thanks for updating this PR.

Line 620:13: E265 block comment should start with '# '
Line 619:13: E265 block comment should start with '# '
Line 568:121: E501 line too long (121 > 120 characters)
Line 347:121: E501 line too long (121 > 120 characters)
Line 271:5: E722 do not use bare 'except'

Line 585:1: W293 blank line contains whitespace
Line 583:121: E501 line too long (124 > 120 characters)
Line 580:121: E501 line too long (124 > 120 characters)
Line 562:121: E501 line too long (122 > 120 characters)
Line 560:121: E501 line too long (124 > 120 characters)
Line 558:121: E501 line too long (124 > 120 characters)
Line 553:121: E501 line too long (124 > 120 characters)
Line 536:121: E501 line too long (126 > 120 characters)

Line 127:121: E501 line too long (170 > 120 characters)
Line 34:121: E501 line too long (148 > 120 characters)

Comment last updated at 2025-01-16 16:10:13 UTC

@PaulaSp3 PaulaSp3 self-assigned this Jul 16, 2024
@PaulaSp3 PaulaSp3 force-pushed the PS_FP_generations branch 3 times, most recently from 4b630bf to 6b4bbc3 Compare September 16, 2024 09:47
@PaulaSp3 PaulaSp3 force-pushed the PS_FP_generations branch 2 times, most recently from a5bdd46 to 28c2002 Compare December 4, 2024 10:30
@PaulaSp3 PaulaSp3 force-pushed the PS_FP_generations branch 3 times, most recently from de803e5 to bb5674e Compare January 16, 2025 15:52
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 699be2d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 69.0% (-0.2% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants