Fix no points in shp reading routines [in2] #1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fso42
requested changes
Nov 19, 2024
Contributor
fso42
left a comment
fso42
left a comment
There was a problem hiding this comment.
The test shapefile is missing
|
Hello @awirb! Thanks for updating this PR.
Comment last updated at 2024-11-20 20:30:43 UTC |
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
fso42
approved these changes
Nov 20, 2024
|
Code Climate has analyzed commit 3a440d5 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 97.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 69.6% (0.0% change). View more on Code Climate. |
Contributor
|
Standardtests ok, apart from known kot pfa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if features have no points but are still available in shp file - remove these features log warning that these area ignored
fixes #1044