add new friction model spatialVoellmy [com1]

[awirb]

This allows the loading of mu/xi file via raster

[pep8speaks]

Hello @awirb! Thanks for updating this PR.

• In the file avaframe/com1DFA/checkCfg.py:

Line 156:121: E501 line too long (138 > 120 characters)
Line 135:121: E501 line too long (124 > 120 characters)
Line 123:121: E501 line too long (127 > 120 characters)
Line 121:121: E501 line too long (127 > 120 characters)
Line 118:121: E501 line too long (140 > 120 characters)

• In the file avaframe/com1DFA/com1DFA.py:

Line 2854:121: E501 line too long (132 > 120 characters)
Line 1126:56: E231 missing whitespace after ','
Line 1125:40: E711 comparison to None should be 'if cond is None:'

• In the file avaframe/com1DFA/deriveParameterSet.py:

Line 743:121: E501 line too long (130 > 120 characters)
Line 334:121: E501 line too long (126 > 120 characters)
Line 334:85: E712 comparison to False should be 'if cond is not False:' or 'if cond:'
Line 286:121: E501 line too long (132 > 120 characters)
Line 259:30: E225 missing whitespace around operator
Line 119:121: E501 line too long (128 > 120 characters)
Line 76:121: E501 line too long (127 > 120 characters)

• In the file avaframe/in1Data/getInput.py:

Line 868:52: E203 whitespace before ':'
Line 863:52: E203 whitespace before ':'
Line 780:36: E203 whitespace before ':'
Line 779:36: E203 whitespace before ':'
Line 487:45: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 474:18: E711 comparison to None should be 'if cond is not None:'
Line 430:46: E711 comparison to None should be 'if cond is not None:'
Line 427:33: E711 comparison to None should be 'if cond is not None:'
Line 417:43: E711 comparison to None should be 'if cond is None:'
Line 349:34: E711 comparison to None should be 'if cond is not None:'

• In the file avaframe/out3Plot/outAIMEC.py:

Line 1706:49: W292 no newline at end of file
Line 1699:9: E231 missing whitespace after ','
Line 1686:44: E241 multiple spaces after ','
Line 1685:39: E241 multiple spaces after ','
Line 1684:39: E241 multiple spaces after ','
Line 1639:78: E127 continuation line over-indented for visual indent
Line 1628:34: E231 missing whitespace after ':'
Line 1607:52: E231 missing whitespace after ','
Line 1580:121: E501 line too long (145 > 120 characters)
Line 1567:52: E231 missing whitespace after ','
Line 1551:111: E203 whitespace before ','
Line 1514:121: E501 line too long (149 > 120 characters)
Line 1514:22: E127 continuation line over-indented for visual indent
Line 1513:121: E501 line too long (126 > 120 characters)
Line 1422:1: E303 too many blank lines (3)
Line 1376:121: E501 line too long (133 > 120 characters)
Line 1376:23: E127 continuation line over-indented for visual indent
Line 1375:38: E225 missing whitespace around operator
Line 1365:20: E251 unexpected spaces around keyword / parameter equals
Line 1313:45: E222 multiple spaces after operator
Line 1259:50: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 1070:121: E501 line too long (121 > 120 characters)
Line 1070:41: E225 missing whitespace around operator
Line 1047:17: E265 block comment should start with '# '
Line 1047:17: E116 unexpected indentation (comment)
Line 1041:9: E265 block comment should start with '# '
Line 983:13: E117 over-indented
Line 972:17: E117 over-indented
Line 971:12: E111 indentation is not a multiple of four
Line 879:67: E127 continuation line over-indented for visual indent
Line 739:5: E265 block comment should start with '# '
Line 724:74: E225 missing whitespace around operator
Line 718:121: E501 line too long (121 > 120 characters)
Line 697:121: E501 line too long (121 > 120 characters)
Line 695:9: E265 block comment should start with '# '
Line 688:121: E501 line too long (124 > 120 characters)
Line 674:121: E501 line too long (123 > 120 characters)
Line 666:121: E501 line too long (138 > 120 characters)
Line 413:49: E231 missing whitespace after ','
Line 413:47: E231 missing whitespace after ','
Line 385:53: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 369:23: E127 continuation line over-indented for visual indent
Line 360:121: E501 line too long (124 > 120 characters)
Line 352:121: E501 line too long (122 > 120 characters)
Line 337:17: E265 block comment should start with '# '
Line 337:17: E116 unexpected indentation (comment)

• In the file avaframe/out3Plot/plotUtils.py:

Line 982:121: E501 line too long (138 > 120 characters)
Line 980:19: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 951:21: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 912:66: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 805:121: E501 line too long (124 > 120 characters)
Line 689:37: E203 whitespace before ':'
Line 688:37: E203 whitespace before ':'
Line 537:15: E711 comparison to None should be 'if cond is not None:'
Line 501:71: E203 whitespace before ':'
Line 501:48: E203 whitespace before ':'
Line 495:71: E203 whitespace before ':'
Line 495:48: E203 whitespace before ':'
Line 482:121: E501 line too long (121 > 120 characters)

• In the file avaframe/tests/test_checkCfg.py:

Line 110:5: E303 too many blank lines (2)
Line 76:5: E303 too many blank lines (2)
Line 26:21: E712 comparison to True should be 'if cond is True:' or 'if cond:'

• In the file avaframe/tests/test_com1DFA.py:

Line 233:37: E711 comparison to None should be 'if cond is None:'
Line 192:37: E711 comparison to None should be 'if cond is None:'

Comment last updated at 2024-11-29 10:52:35 UTC

[fso42]

• Add spatialVoellmy to the description of friction models https://docs.avaframe.org/en/latest/theoryCom1DFA.html#friction-model

[fso42]

Standardtests ok, apart from know Kot, Hof

[qlty-cloud-legacy]

Code Climate has analyzed commit 8492b29 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

The test coverage on the diff in this pull request is 59.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 69.5% (0.0% change).

View more on Code Climate.