Skip to content

Conversation

@fso42
Copy link
Contributor

@fso42 fso42 commented Nov 15, 2024

Switch from subprocess.call to subprocess.popen to be able to handle log and errors better

  • Check with CT on WLV machines...

@fso42 fso42 added the enhancement New feature or request label Nov 15, 2024
@fso42 fso42 self-assigned this Nov 15, 2024
@pep8speaks
Copy link

pep8speaks commented Nov 15, 2024

Hello @fso42! Thanks for updating this PR.

Line 213:9: E303 too many blank lines (2)

Line 209:9: E722 do not use bare 'except'
Line 172:9: E722 do not use bare 'except'

Line 308:121: E501 line too long (159 > 120 characters)
Line 308:17: E116 unexpected indentation (comment)
Line 307:32: W291 trailing whitespace
Line 248:9: E722 do not use bare 'except'
Line 160:13: E121 continuation line under-indented for hanging indent
Line 151:13: E121 continuation line under-indented for hanging indent
Line 139:13: E121 continuation line under-indented for hanging indent
Line 126:13: E121 continuation line under-indented for hanging indent
Line 124:31: E251 unexpected spaces around keyword / parameter equals
Line 124:29: E251 unexpected spaces around keyword / parameter equals
Line 118:13: E121 continuation line under-indented for hanging indent
Line 116:31: E251 unexpected spaces around keyword / parameter equals
Line 116:29: E251 unexpected spaces around keyword / parameter equals
Line 110:13: E123 closing bracket does not match indentation of opening bracket's line
Line 108:27: E251 unexpected spaces around keyword / parameter equals
Line 108:25: E251 unexpected spaces around keyword / parameter equals
Line 91:1: W293 blank line contains whitespace
Line 90:13: E123 closing bracket does not match indentation of opening bracket's line
Line 76:5: E303 too many blank lines (2)

Line 236:121: E501 line too long (159 > 120 characters)
Line 236:17: E116 unexpected indentation (comment)
Line 235:32: W291 trailing whitespace
Line 178:9: E722 do not use bare 'except'
Line 172:9: E303 too many blank lines (2)
Line 125:20: E225 missing whitespace around operator
Line 94:13: E123 closing bracket does not match indentation of opening bracket's line
Line 89:14: E123 closing bracket does not match indentation of opening bracket's line

Line 299:121: E501 line too long (151 > 120 characters)
Line 254:5: E301 expected 1 blank line, found 0
Line 243:9: E303 too many blank lines (3)
Line 223:13: E722 do not use bare 'except'

Line 205:9: E722 do not use bare 'except'

Comment last updated at 2024-11-20 13:08:25 UTC

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Nov 15, 2024

Code Climate has analyzed commit 8a684b0 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3

View more on Code Climate.

  - remove path from pb_tool
  - add qgis to github action
  - disable pytest for now, since qgis cannot be imported
@fso42 fso42 force-pushed the betterErrorFeedback branch from 1b82766 to 8a684b0 Compare November 20, 2024 13:08
@fso42 fso42 merged commit d2f43d7 into main Nov 20, 2024
1 check passed
@fso42 fso42 deleted the betterErrorFeedback branch November 20, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants