Fix to_json_representation_fast to not rely on second-chance external…#133
Merged
Conversation
…ization; add a sorted variant; add some type annotations; improve docs.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the externalization “representation” helpers to make the JSON “fast” path properly externalize objects before dumping, adds a deterministic (sorted-keys) JSON convenience API, and improves typing/docs around these APIs.
Changes:
- Refactor representation dumping through a shared helper (
_to_external_representation) and updateto_json_representation_fastto externalize first. - Add
to_json_representation_sortedand export it publicly. - Improve docstrings and documentation describing the JSON representer and convenience variants.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/nti/externalization/representation.py | Adds shared dump helper, introduces sorted JSON convenience function, updates “fast” JSON path, and improves representer docstrings/typing. |
| src/nti/externalization/init.py | Re-exports to_json_representation_sorted as part of the public API. |
| docs/basics.rst | Documents the JSON convenience variants and shows usage examples. |
| CHANGES.rst | Notes the new sorted variant and the behavioral change to the “fast” variant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ization; add a sorted variant; add some type annotations; improve docs.