Ignore virtual gaps in line objects#2266
Draft
dl3sdo wants to merge 3 commits intoOpenOrienteering:masterfrom
Draft
Ignore virtual gaps in line objects#2266dl3sdo wants to merge 3 commits intoOpenOrienteering:masterfrom
dl3sdo wants to merge 3 commits intoOpenOrienteering:masterfrom
Conversation
Member
Author
|
Note: the 2nd object (motorway) is different as only the border lines are interrupted. This is stored differently in the object compared to virtual gaps. |
In addition to 'addWarning()' 'addWarningOnce()' only adds a warning to the list of warnings if the warning is not yet in the list.
Line objects in .ocd files can contain virtual gaps, i.e., gaps that interrupt the line but keep the object as a single object. Mapper does not yet support virtual gaps and thus ignores them when importing .ocd files. Issue a warning that virtual gaps in line objects are not supported.
Double line objects use symbols with boundary lines (e.g., Wide road symbol). In .ocd files these objects may have gaps in any of the boundary lines. Mapper does not support those kind of gaps and thus ignores them when importing .ocd files. Issue a warning that gaps in double line objects are not supported.
dl3sdo
force-pushed
the
ignore-virtual-gaps
branch
from
2d25290 to
8ce527f
Compare
Member
Author
|
Behaviour with current PR: |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line objects in .ocd files can contain virtual gaps, i.e., gaps that interrupt the line but keep the object as a single object.
Mapper does not yet support virtual gaps and thus ignores them when importing .ocd files.
Issue a warning that virtual gaps in line objects are not supported.
The current PR is a WIP as it depends on merging #2224.
If there a multiple objects with virtual gaps, only one warning should be issued. This is being accomplished by the first commit (which is a modified version of the one in #2124).