Refactor distribute points tool#2305
Draft
dl3sdo wants to merge 1 commit intoOpenOrienteering:masterfrom
Draft
Conversation
The core functionality to distribute points evenly along a path was partly contained in the MapEditorController class (which was marked as a TODO). Move the functionality to the (renamed) DistributePointsDialog class. Add three dots to the submenu item's name to indicate that selecting it will open another window. Remove the 'Settings' since changing them in the dialog was not made persistent.
dl3sdo
force-pushed
the
distribute-points-tool
branch
from
78e6933 to
7b2ecc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core functionality to distribute points evenly along a path was partly contained in the MapEditorController class (which was marked as a TODO).
Move the functionality to the (renamed) DistributePointsDialog class. Add three dots to the submenu item's name to indicate that selecting it will open another window.
Remove the 'Settings' since changing them in the dialog was not made persistent.