Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the legacy ptv.c code into a new track3d.c implementation with Cython bindings while adding 3D tracking support and corresponding tests. Key changes include:
- Adding new 3D tracking routines and Cython binding methods in tracker.pyx and tracker.pxd.
- Introducing new unit tests for 3D tracking in both Python (py_bind/test/) and C (liboptv/tests/check_track3d.c).
- Updating CMake configuration and versioning to integrate the new track3d module.
Reviewed Changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| py_bind/test/test_tracker.py | Added new tests for 3D tracking functionality using forward steps. |
| py_bind/test/test_burgers.py | Introduced similar 3D tracking tests specific to the Burgers case. |
| py_bind/optv/tracker.pyx | Added step_forward_3d and full_forward_3d methods for 3D tracking. |
| liboptv/src/track3d.c | New C implementation for 3D tracking integrating track3d_loop logic. |
| liboptv/tests/check_track3d.c | New test suite for verifying 3D tracking results. |
| CMakeLists.txt files in both liboptv/src and liboptv/tests | Updated to compile and link against the new track3d module. |
Comments suppressed due to low confidence (1)
liboptv/src/track3d.c:65
- [nitpick] Consider renaming 'count1' to a more descriptive identifier such as 'link_count' to improve code readability.
int count1 = 0; // Count of links established in level 1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
liboptvandpy_bindtests pass