Skip to content

Conversation

@zdohnal
Copy link
Member

@zdohnal zdohnal commented Nov 28, 2024

If creating of permanent queue with IPP Everywhere model fails in separate thread, the print queue is created as raw.

It would be great if we remove such queue if creation fails, and marking them as temporary would make them to be removed automatically.

If creating of permanent queue with IPP Everywhere model fails in
separate thread, the print queue is created as raw.

It would be great if we remove such queue if creation fails, and marking
them as temporary would make them to be removed automatically.
Copy link
Member

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zdohnal zdohnal merged commit 04625d9 into OpenPrinting:master Dec 2, 2024
4 of 6 checks passed
@zdohnal
Copy link
Member Author

zdohnal commented Dec 2, 2024

@michaelrsweet I've missed one:

 5377     if ((from = cupsFileOpen(fromppd, "r")) == NULL)
 5378     {
 5379       cupsdLogMessage(CUPSD_LOG_ERROR, "%s: Unable to read generated PPD: %s", printer->name, strerror(errno));
 5380 
 5381       /* Force printer to timeout and be deleted */
 5382       cupsRWLockWrite(&printer->lock);
 5383       printer->state_time = 0;
 5384       cupsRWUnlock(&printer->lock);

since the logic is the same, I'll commit the change directly.

zdohnal added a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants