Skip to content

scheduler/ipp: Skip temporary queue if permanent queue exists with same UUID (Issue #1531) #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abubakarsabir924-cell wants to merge 2 commits into
base: master
Choose a base branch
from
+38 −1
Open

scheduler/ipp: Skip temporary queue if permanent queue exists with same UUID (Issue #1531) #1593

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec533a8
scheduler/ipp: Skip temporary queue creation if permanent queue exist…
abubakarsabir924-cell Jun 2, 2026
9a462ce
Fix segfault: add send_ipp_status before goto add_printer_attributes
abubakarsabir924-cell Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion scheduler/ipp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5500,7 +5500,6 @@ create_local_printer(
send_ipp_status(con, IPP_STATUS_ERROR_FORBIDDEN, _("Only local users can create a local printer."));
return;
}

/*
* Check any other policy limits...
*/
Expand Down Expand Up @@ -5585,7 +5584,45 @@ create_local_printer(
send_ipp_status(con, IPP_STATUS_OK, _("Printer \"%s\" already exists."), printer->name);
goto add_printer_attributes;
}
/* Check for existing permanent queue with same UUID */
{
cupsd_printer_t *perm;
char req_uuid[64] = "";

/* Extract UUID from hostname like: UUID.local */
const char *host_start = strstr(ptr, "://");
if (host_start)
{
host_start += 3;
const char *dot_local = strstr(host_start, ".local");
if (dot_local)
{
size_t ulen = (size_t)(dot_local - host_start);
if (ulen < sizeof(req_uuid))
{
memcpy(req_uuid, host_start, ulen);
req_uuid[ulen] = '\0';
}
}
}

if (req_uuid[0])
{
for (perm = (cupsd_printer_t *)cupsArrayGetFirst(Printers); perm; perm = (cupsd_printer_t *)cupsArrayGetNext(Printers))
{
if (!perm->temporary && perm->uuid && !strcasecmp(req_uuid, perm->uuid + 9))
{
cupsdLogMessage(CUPSD_LOG_DEBUG, "create_local_printer: FOUND MATCHING PERMANENT QUEUE: %s", perm->name);
printer = perm;
printer->state_time = time(NULL);
send_ipp_status(con, IPP_STATUS_OK, _("Printer \"%s\" already exists."), printer->name);
goto add_printer_attributes;
}
}
}
}
}


/*
* Create the printer...
Expand Down
Loading