cupsfilters: ieee1284: fix stack-buffer-overflow in cfIEEE1284NormalizeMakeModel#138
Closed
nomkar24 wants to merge 1 commit intoOpenPrinting:masterfrom
Closed
cupsfilters: ieee1284: fix stack-buffer-overflow in cfIEEE1284NormalizeMakeModel#138nomkar24 wants to merge 1 commit intoOpenPrinting:masterfrom
nomkar24 wants to merge 1 commit intoOpenPrinting:masterfrom
Conversation
Member
|
Please make it properly, without formatting change. |
…rmalizeMakeModel Ensure that the model name pointer (modelptr) is always clamped to the actual string length in the buffer, preventing memory corruption when normalizing printer strings with long manufacturer names. Key changes: - Clamp modelptr to buffer + strlen(buffer) after snprintf calls - Add a safety guard to ensure modelptr never exceeds valid string bounds - Add bounds checks to the while loop that removes repeated manufacturer names - Prevent strncasecmp from performing out-of-bounds reads on the stack fixes OpenPrinting#136 Signed-off-by: Omkar Nanajkar <nomkar2131@gmail.com>
nomkar24
force-pushed
the
fixes_issue_#136
branch
from
fcbe9e8 to
fd701c9
Compare
Contributor
Author
|
ill make a new PR 'Auto format on save' caused this issue. |
Member
|
You don't have to close the existing PR, just force-push to your branch and it will update. |
Contributor
Author
|
sorry for that. I made a new PR can u plz review it @ValdikSS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the model name pointer (modelptr) is always clamped to the actual string length in the buffer, preventing memory corruption when normalizing printer strings with long manufacturer names.
Key changes:
Clamp modelptr to buffer + strlen(buffer) after snprintf calls
Add a safety guard to ensure modelptr never exceeds valid string bounds
Add bounds checks to the while loop that removes repeated manufacturer names
Prevent strncasecmp from performing out-of-bounds reads on the stack
fixes stack-buffer-overflow in cfIEEE1284NormalizeMakeModel() #136