cupsfilters: ieee1284: fix out-of-bounds read in NormalizeMakeModel#139
Merged
tillkamppeter merged 1 commit intoOpenPrinting:masterfrom Mar 25, 2026
Merged
cupsfilters: ieee1284: fix out-of-bounds read in NormalizeMakeModel#139tillkamppeter merged 1 commit intoOpenPrinting:masterfrom
tillkamppeter merged 1 commit intoOpenPrinting:masterfrom
Conversation
When a user-supplied make string is longer than bufsize, snprintf() truncates the output but modelptr was still calculated using the original strlen(make), resulting in modelptr pointing past the end of buffer. A subsequent strncasecmp() call then caused an out-of-bounds read. Key changes: - Add bounds check for modelptr after all snprintf() calls that set it to a fixed offset (Xerox, Kodak, Apple, Seiko, EFI, Canon, Fargo, HP, Kyocera, and user-supplied make string cases) - Add strlen(buffer) guard before accessing buffer at fixed indices in the known multi-word manufacturer name checks (konica minolta, fuji xerox, lexmark international, kyocera mita) - Add strlen(make) < bufsize guard before accessing buffer[strlen(make)] to prevent out-of-bounds access in the make-prefix match check - Keep a catch-all safety clamp for modelptr at the end of the manufacturer block #Fixes OpenPrinting#136 Signed-off-by: Omkar Nanajkar <nomkar2131@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user-supplied make string is longer than bufsize, snprintf() truncates the output but modelptr was still calculated using the original strlen(make), resulting in modelptr pointing past the end of buffer. A subsequent strncasecmp() call then caused an out-of-bounds read.
Key changes: