Skip to content

Apply string removal from OpenRCT2/OpenRCT2#25493 #3385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gymnasiast merged 4 commits into from
Nov 20, 2025
Merged

Apply string removal from OpenRCT2/OpenRCT2#25493 #3385

Gymnasiast merged 4 commits into from
Nov 20, 2025

Conversation

@tygrysek90
Copy link
Contributor

@tygrysek90 tygrysek90 commented Nov 17, 2025

Apply string removal from OpenRCT2/OpenRCT2#25493 to all languages.

Remove lines starting with indices (if present):
["STR_0031", "STR_0033", "STR_0036", "STR_0082", "STR_0084", "STR_0085", "STR_0086", "STR_0087", "STR_0091"]

(New string addition from given PR is handled by the Issue #3383)

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

Check results

For details click the build job and expand Run checks on the CI logs.

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 274 0 (-9) 1719
ca-ES 1 0 (-9) 79
cs-CZ 1 0 (-9) 130
da-DK 16 0 (-9) 308
de-DE 1 0 (-9) 132
en-US 3431 0 1
eo-ZZ 1 0 (-9) 54
es-ES 5 0 (-9) 150
fi-FI 98 0 (-9) 81
fr-CA 3596 0 0
fr-FR 2 0 (-9) 126
gl-ES 1 0 (-9) 78
hu-HU 1 0 (-9) 76
it-IT 23 0 (-9) 122
ja-JP 98 0 (-9) 100
ko-KR 1 0 (-9) 76
nb-NO 183 0 (-9) 153
nl-NL 3 0 (-9) 169
pl-PL 62 0 (-9) 84
pt-BR 1 0 (-9) 123
ru-RU 2 0 (-9) 100
sv-SE 11 0 (-9) 145
tr-TR 510 0 (-9) 91
uk-UA 179 0 (-9) 708
vi-VN 28 0 (-9) 101
zh-CN 11 0 (-9) 22
zh-TW 47 0 (-9) 90

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

@tygrysek90
Copy link
Contributor Author

tygrysek90 commented Nov 17, 2025

I observe there are conflicts appearing because of extra lines in file endings.
I should have done better.
I'll fix that.

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

Check results

For details click the build job and expand Run checks on the CI logs.

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 274 0 (-9) 1719
ca-ES 1 0 (-9) 79
cs-CZ 1 0 (-9) 130
da-DK 16 0 (-9) 308
de-DE 1 0 (-9) 132
eo-ZZ 1 0 (-9) 54
es-ES 5 0 (-9) 150
fi-FI 98 0 (-9) 81
fr-FR 2 0 (-9) 126
gl-ES 1 0 (-9) 78
hu-HU 1 0 (-9) 76
it-IT 23 0 (-9) 122
ja-JP 98 0 (-9) 100
ko-KR 1 0 (-9) 76
nb-NO 183 0 (-9) 153
nl-NL 3 0 (-9) 169
pl-PL 62 0 (-9) 84
pt-BR 1 0 (-9) 123
ru-RU 2 0 (-9) 100
sv-SE 11 0 (-9) 145
tr-TR 510 0 (-9) 91
uk-UA 179 0 (-9) 708
vi-VN 28 0 (-9) 101
zh-CN 11 0 (-9) 22
zh-TW 47 0 (-9) 90

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
en-US 3431 0 1
fr-CA 3596 0 0

@tygrysek90
Copy link
Contributor Author

tygrysek90 commented Nov 17, 2025

Now it should be possible to merge cleanly

@Gymnasiast
Copy link
Member

Gymnasiast commented Nov 20, 2025

Please check the diff for uk-UA.txt, it shows >3000 lines changed :')

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

Check results

For details click the build job and expand Run checks on the CI logs.

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 274 0 (-9) 1719
ca-ES 1 0 (-9) 79
cs-CZ 1 0 (-9) 130
da-DK 16 0 (-9) 308
de-DE 1 0 (-9) 132
eo-ZZ 1 0 (-9) 54
es-ES 5 0 (-9) 150
fi-FI 98 0 (-9) 81
fr-FR 2 0 (-9) 126
gl-ES 1 0 (-9) 78
hu-HU 1 0 (-9) 76
it-IT 23 0 (-9) 122
ja-JP 98 0 (-9) 100
ko-KR 1 0 (-9) 76
nb-NO 183 0 (-9) 153
nl-NL 3 0 (-9) 169
pl-PL 62 0 (-9) 84
pt-BR 1 0 (-9) 123
ru-RU 2 0 (-9) 100
sv-SE 11 0 (-9) 145
tr-TR 510 0 (-9) 91
vi-VN 28 0 (-9) 101
zh-CN 11 0 (-9) 22
zh-TW 47 0 (-9) 90

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
en-US 3431 0 1
fr-CA 3596 0 0
uk-UA 179 9 708

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

Check results

For details click the build job and expand Run checks on the CI logs.

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 274 0 (-9) 1719
ca-ES 1 0 (-9) 79
cs-CZ 1 0 (-9) 130
da-DK 16 0 (-9) 308
de-DE 1 0 (-9) 132
eo-ZZ 1 0 (-9) 54
es-ES 5 0 (-9) 150
fi-FI 98 0 (-9) 81
fr-FR 2 0 (-9) 126
gl-ES 1 0 (-9) 78
hu-HU 1 0 (-9) 76
it-IT 23 0 (-9) 122
ja-JP 98 0 (-9) 100
ko-KR 1 0 (-9) 76
nb-NO 183 0 (-9) 153
nl-NL 3 0 (-9) 169
pl-PL 62 0 (-9) 84
pt-BR 1 0 (-9) 123
ru-RU 2 0 (-9) 100
sv-SE 11 0 (-9) 145
tr-TR 510 0 (-9) 91
uk-UA 179 0 (-9) 708
vi-VN 28 0 (-9) 101
zh-CN 11 0 (-9) 22
zh-TW 47 0 (-9) 90

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
en-US 3431 0 1
fr-CA 3596 0 0

@tygrysek90
Copy link
Contributor Author

tygrysek90 commented Nov 20, 2025

Please check the diff for uk-UA.txt, it shows >3000 lines changed :')

:') CRLF :')
It's now fixed to expected shape

@Gymnasiast Gymnasiast merged commit 0b021b1 into OpenRCT2:master Nov 20, 2025
1 check passed
@Gymnasiast
Copy link
Member

Gymnasiast commented Nov 20, 2025

CRLF

Right, I see. Can you create a separate PR to fix that?

@tygrysek90
Copy link
Contributor Author

tygrysek90 commented Nov 20, 2025

I was thinking about asking you about this :)
I will be happy to address this later in the evening today.

@tygrysek90 tygrysek90 mentioned this pull request Nov 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tygrysek90 @Gymnasiast