Open
Conversation
Contributor
|
This needs a similar entry to the legend, which is sadly in the other repo. |
Author
Added in pull request OpenRailwayMap/OpenRailwayMap#703 |
Author
|
For testing you can use this whole route: https://www.openstreetmap.org/relation/2355657 |
Contributor
|
Needs at least: diff --git a/signals.mml b/signals.mml
index d690324..597bb28 100644
--- a/signals.mml
+++ b/signals.mml
@@ -136,7 +136,7 @@ Layer:
NULL AS construction_usage, NULL AS construction_service,
NULL AS preserved_railway, NULL AS preserved_service,
NULL AS preserved_usage,
- pzb, lzb, atb, atb_eg, atb_ng, atb_vv, etcs, construction_etcs,
+ pzb, lzb, atb, atb_eg, atb_ng, atb_vv, ebicab, etcs, construction_etcs,
railway_train_protection_rank(pzb, lzb, atb, atb_eg, atb_ng, atb_vv, etcs, construction_etcs) AS rank
FROM
(SELECT
@@ -147,6 +147,7 @@ Layer:
tags->'railway:atb-eg' AS atb_eg,
tags->'railway:atb-ng' AS atb_ng,
tags->'railway:atb-vv' AS atb_vv,
+ tags->'railway:ebicab' AS ebicab,
railway_etcs_null_no(tags->'railway:etcs') AS etcs,
railway_etcs_null_no(tags->'construction:railway:etcs') AS construction_etcs
FROM openrailwaymap_osm_line
@@ -173,7 +174,7 @@ Layer:
construction_usage, construction_service,
preserved_railway, preserved_service,
preserved_usage,
- pzb, lzb, atb, atb_eg, atb_ng, atb_vv, etcs, construction_etcs,
+ pzb, lzb, atb, atb_eg, atb_ng, atb_vv, ebicab, etcs, construction_etcs,
railway_train_protection_rank(pzb, lzb, atb, atb_eg, atb_ng, atb_vv, etcs, construction_etcs) AS rank
FROM
(SELECT
@@ -191,6 +192,7 @@ Layer:
tags->'railway:atb-eg' AS atb_eg,
tags->'railway:atb-ng' AS atb_ng,
tags->'railway:atb-vv' AS atb_vv,
+ tags->'railway:ebicab' AS ebicab,
railway_etcs_null_no(tags->'railway:etcs') AS etcs,
railway_etcs_null_no(tags->'construction:railway:etcs') AS construction_etcs,
layerPerhaps even more. Also, The track in Portugal is rendered correctly with this, but nothing in the Scandinavic countries, I guess that's because of the unresolved discussion about tagging in OSM? |
Contributor
Hi! This line is currently rendered as "ATC", together with scandinavian lines. Is this PR still actual, or the label ATC has incorporated the proposed EBICAB? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds EBICAB rendering (both 700 and 900) to the Signals map.