fix: CI error when publishing release#2235
Merged
Merged
Conversation
maximilien-noal
approved these changes
Jun 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a release/CI publishing failure by avoiding Assembly.Location (which can be empty in single-file publish scenarios) when resolving the source-tree Spice86.csproj path for generated-project scaffolding.
Changes:
- Switches the source-tree discovery logic from
Assembly.Location-derived paths toAppContext.BaseDirectoryto support single-file published apps (IL3000 scenario).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kevinferrare
force-pushed
the
fix/ci_again
branch
from
a15e4f7 to
c793273
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.