Refactor Import Validation using FormRequest Classes#1457
Open
Refactor Import Validation using FormRequest Classes#1457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #1432
Deskripsi Ringkas
Pull Request ini bertujuan untuk merapikan logika validasi pada fitur pendataan (import) dengan memindahkan validasi inline dari Controller ke dalam FormRequest class. Langkah ini dilakukan untuk memperbersih kode di Controller (DRY), meningkatkan keterbacaan, dan memudahkan pemeliharaan di masa mendatang.
Perubahan Utama
ImportExcelRequestuntuk aturan dasar import file Excel.ImportAKIAKBRequest,ImportPendudukRequest, dll.) yang menangani aturan spesifik untuk masing-masing modul.$this->validate()pada 8 Controller utama (AKIAKBController,PendudukController,ImunisasiController, dll.) dan menggantinya dengan type-hinted FormRequest.HandlesFileUploaddengan penambahan validasi MIME type yang lebih ketat dan secure filename generation.messages()pada setiap request untuk memberikan pesan kesalahan yang lebih ramah pengguna dalam Bahasa Indonesia.Modul yang Terdampak
Manfaat
Hasil test aplikasi tidak ada error
