Skip to content

Conversation

@emjay0921
Copy link
Contributor

Why is this change needed?

How was the change implemented?

New unit tests

Unit tests executed by the author

How to test manually

Related links

@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 96.19289% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.71%. Comparing base (95434f7) to head (bfe2c85).
⚠️ Report is 90 commits behind head on 17.0.

Files with missing lines Patch % Lines
spp_change_request/models/mixins/source_mixin.py 35.00% 13 Missing ⚠️
spp_change_request_base/models/change_request.py 36.36% 6 Missing and 1 partial ⚠️
..._change_request_base/models/mixins/source_mixin.py 14.28% 6 Missing ⚠️
spp_change_request/models/change_request.py 82.35% 1 Missing and 2 partials ⚠️
spp_change_request/tests/test_models.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #851      +/-   ##
==========================================
+ Coverage   78.05%   79.71%   +1.65%     
==========================================
  Files         771      791      +20     
  Lines       20155    20980     +825     
  Branches     2436     2466      +30     
==========================================
+ Hits        15732    16724     +992     
+ Misses       3854     3676     -178     
- Partials      569      580      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emjay0921 emjay0921 mentioned this pull request Oct 8, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
6.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@emjay0921 emjay0921 marked this pull request as ready for review October 8, 2025 10:54
@github-actions github-actions bot requested a review from reichie020212 October 8, 2025 10:54
@emjay0921
Copy link
Contributor Author

Can you Squash and Merge it @gonzalesedwin1123 ?

@gonzalesedwin1123 gonzalesedwin1123 merged commit c760212 into 17.0 Oct 8, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2025
@emjay0921 emjay0921 deleted the spp-fixes branch October 14, 2025 01:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants