Skip to content

Conversation

@emjay0921
Copy link
Contributor

@emjay0921 emjay0921 commented Oct 31, 2025

Note

Switches area import to fast pandas+JSON batching (with GIS lat/long), adds robust farm season management, introduces targeted custom-filtering, strengthens relation validation, and updates change request assignment/permissions and UIs.

  • Area Import (Base/GIS):
    • Switch to pandas-driven Excel parsing with a new Parsed state, JSON batch storage (spp.area.import.json), and 100-row job batching; major perf/logging improvements and code cleanup.
    • UI: adds Parse action and JSON Data tab; access rule for JSON model; requirements/manifests include pandas.
    • Import pipeline refactored to read JSON batches; language activation validation; simplified duplicate checks in spp.area.write.
    • GIS: extend JSON import to capture LATITUDE/LONGITUDE; add lat/long fields, validation, and GeoJSON point serialization.
  • Farmer Registry:
    • New/expanded farm season workflows: activate/close/force close, overlap control, access rules, views, and tests.
    • Enforce species required on activities; UI tweaks (required fields); hide “Relation Types” menu via hide-menu record.
  • Relations (SPMIS/Social Registry):
    • Enforce relation required and uniqueness constraints; expose relation_inverse; make related lists readonly and tidy columns.
    • SPMIS set as application.
  • Change Requests:
    • “Assigned to me” filters now use assign_to_id; validator/applicator/admin/HQ groups imply write permissions; views aligned across request types.
  • Custom Filter:
    • Add filter_target (both/group/individual) to field metadata; respect in CustomFilterMixin.fields_get; annotate res.partner fields.
  • Land Record:
    • Add dependency on spp_base_common and registry read/write/create access entries.
  • Tests:
    • Add extensive unit/integration tests for area import (pandas/JSON), GIS import, farm seasons; remove legacy spp_area import tests.

Written by Cursor Bugbot for commit b13fbfc. This will update automatically on new commits. Configure here.

emjay0921 and others added 4 commits November 6, 2025 14:26
…nsitive information

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
15.2% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 85.76733% with 115 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.15%. Comparing base (9f54353) to head (b13fbfc).

Files with missing lines Patch % Lines
spp_base_farmer_registry/models/farm_season.py 17.77% 36 Missing and 1 partial ⚠️
spp_area_base/models/area_import.py 87.43% 17 Missing and 8 partials ⚠️
spp_base_social_registry/models/relationship.py 41.66% 14 Missing ⚠️
spp_base_spmis/models/relationship.py 41.66% 14 Missing ⚠️
spp_area_gis/models/area_import.py 84.48% 6 Missing and 3 partials ⚠️
...pp_area_base/tests/test_area_import_integration.py 95.65% 0 Missing and 6 partials ⚠️
spp_area_base/models/area.py 62.50% 2 Missing and 1 partial ⚠️
spp_area_base/tests/test_area_import_raw.py 96.22% 0 Missing and 2 partials ⚠️
...se_farmer_registry/models/agricultural_activity.py 60.00% 1 Missing and 1 partial ⚠️
spp_custom_filter/models/custom_filter_mixin.py 83.33% 1 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #861      +/-   ##
==========================================
+ Coverage   79.83%   80.15%   +0.31%     
==========================================
  Files         805      806       +1     
  Lines       23050    23601     +551     
  Branches     2727     2806      +79     
==========================================
+ Hits        18402    18917     +515     
- Misses       3979     4003      +24     
- Partials      669      681      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emjay0921 emjay0921 marked this pull request as ready for review November 14, 2025 02:24
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on November 17

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@gonzalesedwin1123 gonzalesedwin1123 merged commit d66f6d7 into 17.0 Nov 14, 2025
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2025
@emjay0921 emjay0921 deleted the spp-fixes branch November 17, 2025 03:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants