-
Notifications
You must be signed in to change notification settings - Fork 24
[IMP] fix on reversed archiving counts on large set of records #873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 17.0 #873 +/- ##
==========================================
+ Coverage 79.83% 81.19% +1.35%
==========================================
Files 805 818 +13
Lines 23050 24956 +1906
Branches 2727 2917 +190
==========================================
+ Hits 18402 20262 +1860
+ Misses 3979 3961 -18
- Partials 669 733 +64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gonzalesedwin1123
approved these changes
Nov 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Why is this change needed?
To fix the notification bug where the count of selected to the actual archived is reversed
How was the change implemented?
Patch the dynamic list JS to fix the reversed notification
New unit tests
Unit tests executed by the author
How to test manually
spp_base_commonRelated links
Note
Patches the list view archive/unarchive notification to show correct selected vs processed counts; registers the JS fix and adds brief docs.
DynamicList._toggleArchiveto swap message parameters so the notification shows accurate counts during bulk archive/unarchive (static/src/legacy/js/views/list/list_controller_fix.js).web.assets_backendvia__manifest__.py.readme/BUGFIX_archive_notification.mdexplaining the issue and fix.Written by Cursor Bugbot for commit 6302a1b. This will update automatically on new commits. Configure here.