Skip to content

Conversation

@emjay0921
Copy link
Contributor

@emjay0921 emjay0921 commented Nov 17, 2025

Why is this change needed?

To fix the notification bug where the count of selected to the actual archived is reversed

How was the change implemented?

Patch the dynamic list JS to fix the reversed notification

New unit tests

None

Unit tests executed by the author

None

How to test manually

  • Install or Upgrade spp_base_common
  • Make sure to have records greater than 20000, select all record
  • Archive and check if the notification is now correct

Related links


Note

Patches the list view archive/unarchive notification to show correct selected vs processed counts; registers the JS fix and adds brief docs.

  • Web (Frontend):
    • Patch DynamicList._toggleArchive to swap message parameters so the notification shows accurate counts during bulk archive/unarchive (static/src/legacy/js/views/list/list_controller_fix.js).
    • Register the patch in web.assets_backend via __manifest__.py.
  • Docs:
    • Add readme/BUGFIX_archive_notification.md explaining the issue and fix.

Written by Cursor Bugbot for commit 6302a1b. This will update automatically on new commits. Configure here.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.19%. Comparing base (9f54353) to head (6302a1b).
⚠️ Report is 5 commits behind head on 17.0.

Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #873      +/-   ##
==========================================
+ Coverage   79.83%   81.19%   +1.35%     
==========================================
  Files         805      818      +13     
  Lines       23050    24956    +1906     
  Branches     2727     2917     +190     
==========================================
+ Hits        18402    20262    +1860     
+ Misses       3979     3961      -18     
- Partials      669      733      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emjay0921 emjay0921 changed the title Archiving fix [IMP] fix on reverted archiving counts on large set of records Nov 17, 2025
@emjay0921 emjay0921 changed the title [IMP] fix on reverted archiving counts on large set of records [IMP] fix on reversed archiving counts on large set of records Nov 17, 2025
@emjay0921 emjay0921 marked this pull request as ready for review November 20, 2025 04:52
@emjay0921 emjay0921 removed the request for review from reichie020212 November 20, 2025 04:53
@gonzalesedwin1123 gonzalesedwin1123 merged commit d91fee5 into 17.0 Nov 21, 2025
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants