-
Notifications
You must be signed in to change notification settings - Fork 24
[IMP] auto-refresh on custom field creation and update #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 17.0 #874 +/- ##
==========================================
+ Coverage 81.22% 81.24% +0.01%
==========================================
Files 818 818
Lines 24956 24975 +19
Branches 2917 2917
==========================================
+ Hits 20270 20290 +20
+ Misses 3953 3950 -3
- Partials 733 735 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|



Why is this change needed?
For better optimization when creating and updating custom fields, auto refresh is needed to properly trigger the custom fields UI definition on Group and Individual (Indicator and Additional Details)
How was the change implemented?
Added a JS script to trigger the refresh on successful save, triggered by either creation or update.
New unit tests
Unit tests executed by the author
How to test manually
spp_custom_fields_uiRelated links
Note
Adds JS patch to reload the custom fields form after successful save (with URL safety guard) and wires it via assets; introduces concise tests for onchange behavior and compute updates.
FormController.saveButtonClickedto auto-reload after savingir.model.fieldswithtarget_type.result === falseand errors.web.assets_backendvia__manifest__.py.test_10_onchange_field_category,test_11_onchange_kinds,test_12_onchange_target_type; call_onchange_has_presence()for coverage.computeupdates accordingly; retain type-change error test.CHANGELOG.mdcapturing fixes, safety check, and test additions.Written by Cursor Bugbot for commit 8df8aed. This will update automatically on new commits. Configure here.