[ADD] helpdesk and pos icons

[emjay0921]

Why is this change needed?

How was the change implemented?

New unit tests

Unit tests executed by the author

How to test manually

Related links

---

Note

Updates menu icon mappings to new assets (including helpdesk and POS) and adds tests for phone validation activate/deactivate plus updated icon test.

• Models (spp_base_common/models/ir_module_module.py):
  • Icon mappings: Switch multiple module icons to openspp-icons-* assets.
  • New modules: Add mappings for spp_grm (helpdesk) and point_of_sale with corresponding icons.
• Tests:
  • tests/test_ir_module_module.py: Update expected mail.menu_root_discuss icon to new path.
  • tests/test_phone_number_validation.py: Add test_06_activate_phone_validation and test_07_deactivate_phone_validation to verify state transitions.
• Docs:
  • Update CHANGELOG.md with added phone validation state tests.

^{Written by Cursor Bugbot for commit 31e2f0b. This will update automatically on new commits. Configure here.}

[gemini-code-assist]

Summary of Changes

Hello @emjay0921, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's user interface by integrating custom icons for the Helpdesk and Point of Sale modules. These additions aim to improve visual clarity and navigation, making it easier for users to identify and access these specific functionalities within the system.

Highlights

• Helpdesk Icon Addition: Introduced a new icon for the 'spp_grm' (Helpdesk) module, linking it to its main menu entry.
• Point of Sale Icon Addition: Added a dedicated icon for the 'point_of_sale' module, associating it with its root menu.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds icons for the 'spp_grm' (Helpdesk) and 'point_of_sale' modules. The implementation correctly maps the module names to their menu XML IDs and new icon paths. My feedback focuses on improving the consistency of the icon filenames for better long-term maintainability. I've suggested renaming the new icon files to follow the kebab-case convention used elsewhere in the project.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.22%. Comparing base (9bc1eed) to head (31e2f0b).

Additional details and impacted files

@@            Coverage Diff             @@
##             17.0     #876      +/-   ##
==========================================
- Coverage   81.22%   81.22%   -0.01%     
==========================================
  Files         818      818              
  Lines       24956    24966      +10     
  Branches     2917     2917              
==========================================
+ Hits        20270    20278       +8     
  Misses       3953     3953              
- Partials      733      735       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud