Add a valve model #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dietmarw
force-pushed
the
t57-isolated-valve
branch
from
cc4eb02 to
c8772cc
Compare
Collaborator
Author
|
@boerrebj I'm not expecting you to go through this in detail but if you could just take a quick look at |
dietmarw
force-pushed
the
t57-isolated-valve
branch
2 times, most recently
from
968d379 to
49cf546
Compare
dietmarw
force-pushed
the
t57-isolated-valve
branch
from
49cf546 to
6d376e4
Compare
dietmarw
force-pushed
the
master
branch
2 times, most recently
from
0de3159 to
ef0b3ac
Compare
Collaborator
Author
|
@boerrebj Any chance to have a look at this? I'm pretty sure this can be merged as is, but then again of course I would say that ;-) |
Fixes #75 At the same time a simple valve component is introduced which is based on the `BaseValve` model just like the turbine model is now also based on this. An example model was also added.
Since we now have a `SimpleValve` model a it seems better to emphasise when a turbine is part of the example.
dietmarw-se
force-pushed
the
t57-isolated-valve
branch
from
6d376e4 to
d2b063e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #57 by adding a base class of a valve which then in turn is used by a new valve model and a modified simple turbine model.