[dammi] Remove mig tables#3641
Merged
Merged
Conversation
lint some
* cleanup get_stats/count method * improve exception stats output * handle listdir patching in migrate_previous
…diff * return optional cleanup * improve and fix test mig 100 and base test class * fix mig 101 * more cleanups
* decuple BaseMigration and BaseMigrationRouteTestCase * remove finalize commands * fix migration route tests
* delete unwanted comments * use only empty values within replace tables * catch only first Exception * various improvements from PR 3548
hjanott
force-pushed
the
remove_mig_tables
branch
from
7675730 to
398d5d4
Compare
hjanott
force-pushed
the
remove_mig_tables
branch
from
398d5d4 to
0e6dd96
Compare
luisa-beerboom
requested changes
Jul 9, 2026
| MigrationHelper.migrate_thread_stream_can_be_closed = False | ||
| MigrationHelper.migrate_thread_exception = None | ||
|
|
||
| def finalize(self) -> None: |
Member
There was a problem hiding this comment.
Merging this into #3643 is going to be fuuuuun (x_x)
luisa-beerboom
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims at improving the test setup and applying the already sql diff from file.
It removes the migration tables, the finalize command and unused migration states.
Instead it applies the schema diff and operates on the tables directly using only one transaction.
It slims down the replace tables to basically only the collection names.
It changes the directory structure and file naming convention for the migrations.
Decouples the migration and migration route test cases again as the route test cases do not need a reset of the schema and it would lead to other unwanted side effects. Thus we are generating some code redundancy.
There is still one error in
test_play_with_migrationswhich is intended as the test_migration will get removed again.