Added frontent for maximum available yes votes#6390
Open
potatojuicemachine wants to merge 1 commit into
Open
Conversation
Author
|
Note: I added a TODO comment for a small bug I discovered along the way in client/src/app/site/pages/meetings/modules/poll/services/voting.service/voting.service.ts , that I didn't know how to fix. I can remove the comment if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the frontend for the maximum available yes votes that has been implemented recently in the backend. It is a response (and hopefully closes) to this issue: #6351 .
Creating a new approval poll will looks like this:

I added the information to the meta component so it looks like this:

I added the information to the top of the vote form:

When enough yes votes are selected the inputs will be disabled so they look like this:

Looking forward to your feedback.
Have a nice day.