[vote] Add field for entitled_users#551
Open
ostcar wants to merge 23 commits into
Open
Conversation
Member
Author
|
I merged the split poll_ballot collection into this PR, since this would contain a lot of merge conflicts in the vote service |
vkrasnovyd
approved these changes
Jul 15, 2026
vkrasnovyd
left a comment
Contributor
There was a problem hiding this comment.
New fields looks good to me.
Data miration indeed seems to be not needed, so I wouldn't mention this field in the Migration.md too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@vkrasnovyd I would say, we need no migration for that. This field is different then the old
poll/entitled_users_at_stop. We don't have the data in the old system, to create a realentitled_meeting_usersfield. We could only create data, that contains the meeting_users at stop. But this would be wrong.The client has to work with polls, that do not have the data anyway (when delegation is activated).