-
Notifications
You must be signed in to change notification settings - Fork 2
Feature | Extend Swagger Coverage for controller OAuth2SponsorshipTypeApiController #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
95cf5bd to
80c39c4
Compare
80c39c4 to
ffe092c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting for tags needed.
Current: tags: ["SponsorshipTypes"]
Expected: tags: ["Sponsorship Types"]
Add SummitScopes::ReadAllSummitData to the security schema scopes in SponsorshipTypeOauthSchemas.php so:
scopes: [
SummitScopes::ReadSummitData => 'Read Sponsorship Types Data',
SummitScopes::ReadAllSummitData => 'Read All Sponsorship Types Data', // ← Add this line
SummitScopes::WriteSummitData => 'Write Sponsorship Types Data',
],
Also add operationId where needed.
ffe092c to
9421fa4
Compare
9421fa4 to
53f5b6d
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to change
tags: ["SponsorshipTypes"],
to
tags: ["Sponsorship Types"],
f7c2526 to
e15083a
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
smarcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ref: https://app.clickup.com/t/86b6wkh5w