Skip to content

Conversation

@andrestejerina97
Copy link
Contributor

@andrestejerina97 andrestejerina97 commented Oct 14, 2025

@andrestejerina97 andrestejerina97 self-assigned this Oct 31, 2025
@andrestejerina97 andrestejerina97 force-pushed the feature/add-sponsorship-type-api-swagger branch from 95cf5bd to 80c39c4 Compare November 11, 2025 21:00
@andrestejerina97 andrestejerina97 marked this pull request as ready for review November 11, 2025 21:00
@andrestejerina97 andrestejerina97 force-pushed the feature/add-sponsorship-type-api-swagger branch from 80c39c4 to ffe092c Compare November 14, 2025 16:03
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting for tags needed.
Current: tags: ["SponsorshipTypes"]
Expected: tags: ["Sponsorship Types"]

Add SummitScopes::ReadAllSummitData to the security schema scopes in SponsorshipTypeOauthSchemas.php so:

scopes: [
    SummitScopes::ReadSummitData => 'Read Sponsorship Types Data',
    SummitScopes::ReadAllSummitData => 'Read All Sponsorship Types Data',  // ← Add this line
    SummitScopes::WriteSummitData => 'Write Sponsorship Types Data',
],

Also add operationId where needed.

@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-sponsorship-type-api-swagger branch from ffe092c to 9421fa4 Compare December 9, 2025 18:50
@matiasperrone-exo matiasperrone-exo changed the title feat: Add openapi documentation for OAuth2SponsorshipTypeApiController feat | Extend Swagger Coverage for controller OAuth2SponsorshipTypeApiController Dec 9, 2025
@matiasperrone-exo matiasperrone-exo added the documentation Improvements or additions to documentation label Dec 9, 2025
@matiasperrone-exo matiasperrone-exo changed the title feat | Extend Swagger Coverage for controller OAuth2SponsorshipTypeApiController Feature | Extend Swagger Coverage for controller OAuth2SponsorshipTypeApiController Dec 9, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-sponsorship-type-api-swagger branch from 9421fa4 to 53f5b6d Compare December 9, 2025 20:33
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to change
tags: ["SponsorshipTypes"],
to
tags: ["Sponsorship Types"],

@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-sponsorship-type-api-swagger branch from f7c2526 to e15083a Compare December 10, 2025 21:08
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit d9c9bd2 into main Dec 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants