Skip to content

Conversation

@andrestejerina97
Copy link
Contributor

@andrestejerina97 andrestejerina97 added the documentation Improvements or additions to documentation label Oct 17, 2025
@andrestejerina97 andrestejerina97 self-assigned this Oct 17, 2025
@andrestejerina97 andrestejerina97 force-pushed the feature/add-summit-notification-api-swagger branch from e5e2d6f to 605e42f Compare November 18, 2025 19:02
@andrestejerina97 andrestejerina97 force-pushed the feature/add-summit-notification-api-swagger branch from 605e42f to 12cea6a Compare November 18, 2025 19:03
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SummitNotificationsAuthShemas.php
Namespace should be App\Swagger\schemas
Filename typo:
SummitNotificationsAuthShemas.php should be SummitNotificationsAuthSchemas.php

SummitPushNotificationSchemas.php
Namespace App\Swagger\Summit should be App\Swagger\schemas

Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SummitPushNotificationSchemas.php has namespace App\Swagger\Summit; should be namespace App\Swagger\schemas;

@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-summit-notification-api-swagger branch from fcf5d42 to d7ba204 Compare December 10, 2025 21:43
@matiasperrone-exo
Copy link
Contributor

Thanks @caseylocker for the comments. Now is ready to review again.

Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@smarcet smarcet force-pushed the main branch 4 times, most recently from c6ecdd0 to 728ae67 Compare December 17, 2025 00:43
Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit b7de2f7 into main Dec 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants