-
Notifications
You must be signed in to change notification settings - Fork 2
Feature | Extend Swagger Coverage for controller OAuth2SummitNotificationsApiController #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e5e2d6f to
605e42f
Compare
605e42f to
12cea6a
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SummitNotificationsAuthShemas.php
Namespace should be App\Swagger\schemas
Filename typo:
SummitNotificationsAuthShemas.php should be SummitNotificationsAuthSchemas.php
SummitPushNotificationSchemas.php
Namespace App\Swagger\Summit should be App\Swagger\schemas
3253a72 to
fcf5d42
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SummitPushNotificationSchemas.php has namespace App\Swagger\Summit; should be namespace App\Swagger\schemas;
fcf5d42 to
d7ba204
Compare
|
Thanks @caseylocker for the comments. Now is ready to review again. |
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
c6ecdd0 to
728ae67
Compare
smarcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ref: https://app.clickup.com/t/86b6wkh9f