-
Notifications
You must be signed in to change notification settings - Fork 2
Feature | Extend Swagger Coverage for controller OAuth2SummitEventsApiController
#478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature | Extend Swagger Coverage for controller OAuth2SummitEventsApiController
#478
Conversation
08f38e3 to
acf6356
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasperrone-exo you have duplicate operationid values which are causing the doc generation to fail. Please fix and regenerate docs locally to verify before resubmitting.
While you're in there:
Line 84 & 133 in OAuth2SummitEventsApiControllerSchemas.php
Typo in description:
'RSVP external link, only if rsvp_template_id is not se'
Should be: '...is not set'
Thanks.
|
Thanks @caseylocker for the comments. Now is ready to review again |
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openapi-generate check is failing as there is a class defined in 2 places. looks like a merge of pr 400 created duplicate a PaginatedTagsResponseSchema . Rebase and remove duplicate definition before submitting. Double check that the ci checks work as well.
…ntroller` Signed-off-by: Matias Perrone <github@matiasperrone.com>
Signed-off-by: Matias Perrone <github@matiasperrone.com>
Signed-off-by: Matias Perrone <github@matiasperrone.com>
Signed-off-by: Matias Perrone <github@matiasperrone.com>
Signed-off-by: Matias Perrone <github@matiasperrone.com>
Signed-off-by: Matias Perrone <github@matiasperrone.com>
Signed-off-by: Matias Perrone <github@matiasperrone.com>
Signed-off-by: Matias Perrone <github@matiasperrone.com>
Signed-off-by: Matias Perrone <github@matiasperrone.com>
1d696e9 to
b26d9ce
Compare
|
Thanks @caseylocker for catching that one. |
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Task:
Ref: https://app.clickup.com/t/86b6wkhda