Skip to content

docs: add object naming best practices#9

Open
NTchrist wants to merge 3 commits into
OpenStorageNetwork:mainfrom
NTchrist:docs-update-tips
Open

docs: add object naming best practices#9
NTchrist wants to merge 3 commits into
OpenStorageNetwork:mainfrom
NTchrist:docs-update-tips

Conversation

@NTchrist

Copy link
Copy Markdown

Adds naming convention recommendations for objects, guidance for compatibility with downstream filesystems, tools, and libraries.

@georgiastuart georgiastuart left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think moving the call to action (use these characters) above the reasons why to not use other characters is the most clear.

Comment thread content/docs/tips.md Outdated

However, a forward slash should not be used within the name of an individual file or directory.

For broad compatibility with tools, libraries, and filesystems, use lower-case letters, numbers, spaces, hyphens (`-`), underscores (`_`), and periods (`.`) in file and folder names. Avoid unnecessary special characters, names that differ only by capitalization, and leading or trailing spaces or periods.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to the top of the section to emphasize it as what TO do over what NOT to do?

Comment thread content/docs/tips.md
## Best Practices

### Naming Conventions

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark this clearly as "this don't use these characters and why." I think it may be misinterpreted at a glance.

Comment thread content/docs/tips.md Outdated

However, a forward slash should not be used within the name of an individual file or directory.

For broad compatibility with tools, libraries, and filesystems, use lower-case letters, numbers, spaces, hyphens (`-`), underscores (`_`), and periods (`.`) in file and folder names. Avoid unnecessary special characters, names that differ only by capitalization, and leading or trailing spaces or periods.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to the top to emphasize what TO do rather than what not to do.

@georgiastuart

Copy link
Copy Markdown
Collaborator

Whoops I thought it hadn't submitted my review the first time so there are two pretty identical reviews

@NTchrist

Copy link
Copy Markdown
Author

I believe that is what you asked for. Please review at your convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants