Refactor game actions to use type safe #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvpm
added
topic:core
topic:codestyle
enhancement
Spartan322
reviewed
Nov 22, 2025
Spartan322
reviewed
Nov 22, 2025
Spartan322
reviewed
Nov 22, 2025
Spartan322
reviewed
Nov 22, 2025
Spartan322
reviewed
Nov 22, 2025
wvpm
force-pushed
the
type_safe_game_actions
branch
3 times, most recently
from
1ac3110 to
3ebe474
Compare
wvpm
force-pushed
the
type_safe_game_actions
branch
from
3ebe474 to
453bd0b
Compare
Spartan322
approved these changes
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely refactored GameActions to use the X-macro pattern.
This allows us to define new game actions and their arguments with 1 line.
For example
X(set_ai, country_and_boolean_t) \The macros generate an enum entry, the switch case, the argument type alias and the method definition.
All you need to do is write the implementation in the cpp.
The game actions implementations have been rewritten and province number vs province index bugs resolved.