Restrict fixed_point_t constructor to integral_max_size_4 #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvpm
force-pushed
the
restrict_fixed_point_t_constructor_to_integral_max_size_4
branch
from
0a8cad0 to
ab1e884
Compare
Spartan322
reviewed
Jan 2, 2026
wvpm
force-pushed
the
restrict_fixed_point_t_constructor_to_integral_max_size_4
branch
from
ab1e884 to
8adaf86
Compare
wvpm
force-pushed
the
restrict_fixed_point_t_constructor_to_integral_max_size_4
branch
from
8adaf86 to
54dd70c
Compare
Spartan322
approved these changes
Jan 2, 2026
Spartan322
deleted the
restrict_fixed_point_t_constructor_to_integral_max_size_4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old constructor allowed int64 which isn't intended. Int64 should be converted via
parse_raw(int64)