Remove fixed_point_t::parse(int64_t) #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spartan322
reviewed
Jan 2, 2026
Spartan322
reviewed
Jan 2, 2026
wvpm
force-pushed
the
remove_fixed_point_parse
branch
2 times, most recently
from
8f61e84 to
a52f6fa
Compare
wvpm
force-pushed
the
remove_fixed_point_parse
branch
from
a52f6fa to
d789d5f
Compare
Spartan322
approved these changes
Jan 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed_point_t::parse(int64_t)caused int64_t to lose the most significant bits without warning.If needed, use
fixed_point_t::parse_capped(std::integeral)which uses fallbacks and logs.Prefably, use int32_t and the constructor.